mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 43667: Modified existing scheduler tests as an aftermath of pipelining change.
Date Sat, 27 Feb 2016 04:45:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43667/
-----------------------------------------------------------

(Updated Feb. 27, 2016, 4:45 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Merged r43664 with this review.


Bugs: MESOS-3570
    https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
-------

This change modifies the existing tests to handle the new `connected/disconnected` semantics
that were introduced as a result of the pipelining change.

Now `connected` is possible to invoked more then once i.e. during test shutdown, the master
closed the event stream making us call the `disconnected` callback. However, the master detector
can still detect the same master and establish a connection to it while it is shutting down
leading to `connected` callback be invoked again in some cases.


Diffs (updated)
-----

  src/tests/master_maintenance_tests.cpp b98eedec388813ee795dd83ccc5ff27338209475 
  src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 

Diff: https://reviews.apache.org/r/43667/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message