mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jojy Varghese <j...@mesosphere.io>
Subject Re: Review Request 43969: Added test for Appc image fetcher.
Date Sat, 27 Feb 2016 04:04:15 GMT


> On Feb. 27, 2016, 12:21 a.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_appc_tests.cpp, line 539
> > <https://reviews.apache.org/r/43969/diff/1/?file=1268497#file1268497line539>
> >
> >     We might want to serve multiple images. Can you make it more general so that
we can serve any files under 'server' directory?

I thought this is a good start and we can expand as we go. We could add a map of `name->path`
in the test fixture. I can add a TODO.


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43969/#review121010
-----------------------------------------------------------


On Feb. 24, 2016, 11:19 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43969/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 11:19 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4748
>     https://issues.apache.org/jira/browse/MESOS-4748
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added simple appc Fetcher test with mock HTTP image server.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 9d9779ac04e32348ce0e28da54fd7aa039a7fbcd

> 
> Diff: https://reviews.apache.org/r/43969/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message