mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 43662: Added support for pipelining calls to the scheduler library.
Date Sat, 27 Feb 2016 02:06:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43662/#review121046
-----------------------------------------------------------


Fix it, then Ship it!





src/scheduler/scheduler.cpp (line 276)
<https://reviews.apache.org/r/43662/#comment182632>

    Can you expand more here. Need to say that we make a copy here because 'master' and 'connectionId'
values might change by the time the 2nd `http::connect()` or `connected()` gets called.



src/scheduler/scheduler.cpp (line 282)
<https://reviews.apache.org/r/43662/#comment182631>

    s/master.get()/master_/



src/scheduler/scheduler.cpp (line 302)
<https://reviews.apache.org/r/43662/#comment182633>

    "Ignoring stale connection attempt"
    
    This can happen even without master failover.



src/scheduler/scheduler.cpp (line 358)
<https://reviews.apache.org/r/43662/#comment182635>

    ditto. VLOG(1) ?



src/scheduler/scheduler.cpp (line 392)
<https://reviews.apache.org/r/43662/#comment182636>

    I think this will read better as
    
    if (state == CONNECTED || state == SUBSCRIBING || state == SUBSCRIBED)


- Vinod Kone


On Feb. 27, 2016, 1:22 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43662/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2016, 1:22 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3570
>     https://issues.apache.org/jira/browse/MESOS-3570
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, the scheduler library used to chain calls on previous call responses. This
was inherently slow. This change adds support for pipelining all calls to the master on a
single connection via the `http::Connection` abstraction in libprocess.
> 
> This change also adds support for handling various error scenarios when we notice a disconnection
instead of just relying on the master detector for invoking the `disconnected` callback.
> 
> 
> Diffs
> -----
> 
>   src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 
> 
> Diff: https://reviews.apache.org/r/43662/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message