mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 44113: Cleaned up assertions in test cases.
Date Sat, 27 Feb 2016 01:56:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44113/
-----------------------------------------------------------

(Updated Feb. 27, 2016, 1:56 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
-------

Rebase.


Repository: mesos


Description
-------

Ensure that `EXPECT_EQ` and friends use "expected, actual" as the
order of arguments.


Diffs (updated)
-----

  src/tests/containerizer/docker_spec_tests.cpp 5799dc9c871c6ccaddb209ab7ec1112b192f3d41 
  src/tests/containerizer/docker_tests.cpp 620819330847a10d9dcd817968df9d2b180a9a29 
  src/tests/containerizer/fs_tests.cpp 29e43877612fa151e6f6d79268a7411272a7bfeb 
  src/tests/containerizer/provisioner_backend_tests.cpp 25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8

  src/tests/module_tests.cpp 121d65337bdf29f6049ac44bfd903a1f5ea1a09d 
  src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff 
  src/tests/sorter_tests.cpp 22bc618f9b4958fbd8e6c5dfee94b26fe13ec47a 

Diff: https://reviews.apache.org/r/44113/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message