mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhiwei Chen <zhiwc...@cn.ibm.com>
Subject Re: Review Request 43999: Use relative path to create libraries symbolic link.
Date Sat, 27 Feb 2016 01:55:20 GMT


> On Feb. 27, 2016, 1:36 a.m., Kapil Arya wrote:
> > src/Makefile.am, lines 2010-2011
> > <https://reviews.apache.org/r/43999/diff/1/?file=1270783#file1270783line2010>
> >
> >     Minor nit. Can we fix the alignment to four spaces to be consistent with the
rest of the block? Also align the trailing slashes? (It's possible that they are already aligned,
just not showing up on the RB diff.

Thanks, it was aligned in git diff.


- Zhiwei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43999/#review120894
-----------------------------------------------------------


On Feb. 26, 2016, 4:18 p.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43999/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 4:18 p.m.)
> 
> 
> Review request for mesos, James Peach and Kapil Arya.
> 
> 
> Bugs: MESOS-4774
>     https://issues.apache.org/jira/browse/MESOS-4774
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use relative path to create libraries symbolic link.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
> 
> Diff: https://reviews.apache.org/r/43999/diff/
> 
> 
> Testing
> -------
> 
> After make install, the library links will be relative path.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message