mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 44003: CMake: Add CMakeLists for master executable build.
Date Fri, 26 Feb 2016 23:52:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44003/#review120960
-----------------------------------------------------------




src/master/CMakeLists.txt (line 17)
<https://reviews.apache.org/r/44003/#comment182517>

    It looks like there aren't actually any source files to add, so perhaps we should do away
with this comment?
    
    I recommend moving the comment `THE PROCESS SLAVE...` from a couple lines below, to this
spot. That way you get rid of the awkward indentation below.



src/master/CMakeLists.txt (line 20)
<https://reviews.apache.org/r/44003/#comment182579>

    When we move the comment below, could we also get rid of this space?



src/master/CMakeLists.txt (line 29)
<https://reviews.apache.org/r/44003/#comment182580>

    A list of targets for dependencies should probably be maintained in the `*Configure.cmake`
scripts, _i.e._, we should be writing something like:
    
    ```
    add_dependencies(${MASTER_TARGET} ${MASTER_DEPENDENCIES})
    ```
    
    If I did something different in another place, I was being very sloppy indeed!



src/master/CMakeLists.txt (line 33)
<https://reviews.apache.org/r/44003/#comment182581>

    Same comment as the dependencies -- we should make this something like the following,
much like we did with the agent.
    
    ```
    target_link_libraries(${MASTER_TARGET} ${MASTER_LIBS})
    ```


- Alex Clemmer


On Feb. 25, 2016, 2:10 p.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44003/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2016, 2:10 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Bugs: MESOS-4773
>     https://issues.apache.org/jira/browse/MESOS-4773
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Add CMakeLists for master executable build.
> 
> 
> Diffs
> -----
> 
>   src/master/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44003/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message