mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cong Wang <xiyou.wangc...@gmail.com>
Subject Re: Review Request 44026: Moved future tests into future_tests.cpp.
Date Fri, 26 Feb 2016 23:12:05 GMT


> On Feb. 26, 2016, 1:45 a.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp, lines 1764-1776
> > <https://reviews.apache.org/r/44026/diff/1/?file=1271139#file1271139line1764>
> >
> >     Should this be moved to `future_tests.cpp` too?

Yes, it should, because this is a pure Future test, not related to process.


- Cong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44026/#review120813
-----------------------------------------------------------


On Feb. 25, 2016, 5:59 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44026/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2016, 5:59 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved future tests into future_tests.cpp.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/future_tests.cpp ded1aaed25876d45e33b4a27fffc6a5c46ca92f5

>   3rdparty/libprocess/src/tests/process_tests.cpp e9bf80ee69f4add299cb828ed3245ac07398943c

> 
> Diff: https://reviews.apache.org/r/44026/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message