mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 43938: Required jsonifying of generic protobuf to be explicit opt-in [stout].
Date Fri, 26 Feb 2016 21:38:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43938/#review120963
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 624)
<https://reviews.apache.org/r/43938/#comment182519>

    This needs a comment, I think.



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 625)
<https://reviews.apache.org/r/43938/#comment182520>

    Is this the best name for this type? Not sure there's a better name, but `JSON::Protobuf`
doesn't necessarily imply to me that the type names a certain representation of `google::protobuf::Message`.
What about `JSON::RawProtobuf`?


- Neil Conway


On Feb. 26, 2016, 8:39 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43938/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 8:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-4754
>     https://issues.apache.org/jira/browse/MESOS-4754
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See JIRA ticket.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp eb5502c4987da5593169a86b21f60c01aa5b5170

>   3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp 22f70f7536c6f5d24ff59228d8ba7bf41319fd4a

>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 8dd9cfd3e7d1e3ab4ace87066a43a3094b776d82

> 
> Diff: https://reviews.apache.org/r/43938/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message