mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.
Date Wed, 24 Feb 2016 19:23:07 GMT


> On Feb. 24, 2016, 5:16 a.m., Kevin Klues wrote:
> > support/push-reviews.py, lines 123-125
> > <https://reviews.apache.org/r/43552/diff/2/?file=1263874#file1263874line123>
> >
> >     Ah, I see it now. There is another call to `if not options['dry_run']` inside
the `close_reviews()` call which protects it from actually closing it on rb. Seems like this
could be consolidated somehow, since it's a little confusing at first glance, but may not
be worth the effort.

I've removed the "if reviews:" to avoid confusion.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43552/#review120452
-----------------------------------------------------------


On Feb. 22, 2016, 4:52 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43552/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 4:52 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park.
> 
> 
> Bugs: MESOS-3929
>     https://issues.apache.org/jira/browse/MESOS-3929
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This script allows committers to push locally applied review chain to the ASF
> git repo and mark the reviews as submitted.
> 
> 
> Diffs
> -----
> 
>   support/push-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43552/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message