mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 43848: Used `size_t` to track number of frameworks per role.
Date Tue, 23 Feb 2016 16:20:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43848/#review120326
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43848]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 7:54 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43848/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 7:54 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Per informal project style, we prefer using unsigned types to
> represent non-negative quantities.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 0d39d3f3b5f4ff7f62f9de7200d062845c71818a

> 
> Diff: https://reviews.apache.org/r/43848/diff/
> 
> 
> Testing
> -------
> 
> make check on OSX
> 
> Compilation on Linux with GCC 5.3
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message