mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 43809: Moved composing containerizer to composing folder.
Date Sun, 21 Feb 2016 11:27:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43809/#review120068
-----------------------------------------------------------



Patch looks great!

Reviews applied: [42710, 43809]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 21, 2016, 9:50 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43809/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2016, 9:50 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4716
>     https://issues.apache.org/jira/browse/MESOS-4716
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Mesos now support three kind for containerizers: Mesos, Docker
> and Compose. The Mesos containerizer is under slave/containerizer/mesos
> and it is better to move composing containerizer to slave/containerizer/composing.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
>   src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e 
>   src/slave/containerizer/composing.hpp  
>   src/slave/containerizer/composing.cpp 15d059f0bbda4e8cb93c65c09327dde1e34d3e7b 
>   src/slave/containerizer/containerizer.cpp 59904684cdeb17ef2b42092a3558802c42bfb6bd

>   src/tests/containerizer/composing_containerizer_tests.cpp e7e3b622b6606a812aef046c761bf92368d34af2

> 
> Diff: https://reviews.apache.org/r/43809/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message