mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shuai Lin <linshuai2...@gmail.com>
Subject Re: Review Request 43701: Added a command executor based on the new V1 API.
Date Sun, 21 Feb 2016 07:52:02 GMT


> On Feb. 18, 2016, 4:07 p.m., Shuai Lin wrote:
> > src/slave/flags.cpp, line 693
> > <https://reviews.apache.org/r/43701/diff/1/?file=1253452#file1253452line693>
> >
> >     One space before `\n`, otherwise the word would be mixed with the first word
of the next line.
> 
> Qian Zhang wrote:
>     I do not think we will have such issue, you can take a look at the all other existing
flags, they all do the same way. And here is the output when I run "./src/mesos-slave --help":
>     # ./src/mesos-slave --help
>     Usage: lt-mesos-slave [options]
>     ...
>     --[no-]http_command_executor                      Enable mesos containerizer to use
HTTP command executor which uses
>                                                       executor HTTP API to interact with
Mesos agent. If false, the old
>                                                       command executor which uses executor
driver API will be used.
>                                                       default: false)
>     ...
>     
>     I think the output is desired.

You're right. I didn't note there is an explicit `"\n"` in the end of every line.


- Shuai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43701/#review119623
-----------------------------------------------------------


On Feb. 20, 2016, 1:44 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43701/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2016, 1:44 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
>     https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a command executor based on the new V1 API.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md b04e873009dc783cc50eb02a459f0587d020ad23 
>   include/mesos/v1/mesos.proto e4224afe2245d649afa1a6c97bae26c215e6fada 
>   src/Makefile.am 27aec37524aa33211e0ca4594e127ebb4279e9b0 
>   src/launcher/http_executor.cpp PRE-CREATION 
>   src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 
>   src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a 
>   src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
> 
> Diff: https://reviews.apache.org/r/43701/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message