mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 43701: Added a command executor based on the new V1 API.
Date Fri, 19 Feb 2016 09:18:17 GMT


> On Feb. 18, 2016, 1:42 p.m., Jian Qiu wrote:
> > src/launcher/http_executor.cpp, line 118
> > <https://reviews.apache.org/r/43701/diff/1/?file=1253450#file1253450line118>
> >
> >     this method and other methods not implementation of the virtual method should
be private

I think other executors or schedulers based on V1 HTTP API also do it in the similar way,
you can take a look at `EventCallScheduler` and `TestExecutor`.


> On Feb. 18, 2016, 1:42 p.m., Jian Qiu wrote:
> > src/launcher/http_executor.cpp, line 202
> > <https://reviews.apache.org/r/43701/diff/1/?file=1253450#file1253450line202>
> >
> >     should this block be put in a separate function?

Ha, personally I agree! But I just followed the old command executor, you can take a look
at `CommandExecutorProcess::launchTask()`, I would like to keep them consistent for now :-)


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43701/#review119584
-----------------------------------------------------------


On Feb. 18, 2016, 9:09 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43701/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 9:09 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
>     https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a command executor based on the new V1 API.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
>   src/Makefile.am 54ebe91643a17017c00cdbd5dfc8ce1a021579d5 
>   src/launcher/http_executor.cpp PRE-CREATION 
>   src/slave/flags.hpp bd52b4f9816b271a9d2728ae6915f8e24b74d716 
>   src/slave/flags.cpp d4b4e5201bb3a7e8edd0ab2481328fc91cd8f974 
>   src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
> 
> Diff: https://reviews.apache.org/r/43701/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message