mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 43657: Fixed MasterDetector pointer leak in scheduler library.
Date Thu, 18 Feb 2016 04:54:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43657/
-----------------------------------------------------------

(Updated Feb. 18, 2016, 4:54 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Moved from `process::Owned` to `std::shared_ptr` similar to `MesosSchedulerDriver`. This also
helps when passing a `MasterDetector` object while testing.


Bugs: MESOS-3570
    https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
-------

Moved the detector pointer to `process::Owned` so that it is cleaned up later.


Diffs (updated)
-----

  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 

Diff: https://reviews.apache.org/r/43657/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message