mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 43676: Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.
Date Wed, 17 Feb 2016 23:45:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43676/#review119551
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43676]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 17, 2016, 10:03 p.m., Kevin Devroede wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43676/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2016, 10:03 p.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Bugs: MESOS-4693
>     https://issues.apache.org/jira/browse/MESOS-4693
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.
> 
> 
> Diffs
> -----
> 
>   src/hook/manager.hpp 8ab331ae28d29a006a7c9878ffb619f2cdd03a42 
>   src/hook/manager.cpp 704b166725c0b356f2acb9bb1539a72cefd9b7ae 
> 
> Diff: https://reviews.apache.org/r/43676/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Devroede
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message