mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Review Request 43641: Removed unnecessary parameter from validation function.
Date Wed, 17 Feb 2016 20:46:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43641/
-----------------------------------------------------------

Review request for mesos, Michael Park and Neil Conway.


Bugs: MESOS-3940
    https://issues.apache.org/jira/browse/MESOS-3940


Repository: mesos


Description
-------

Removed unnecessary parameter from validation function.

Since unreserve operations are now possible without a principal, the `bool hasPrincipal` parameter
to the Unreserve operation validation function is no longer necessary.


Diffs
-----

  src/master/http.cpp f92212bf69f9db51d729347fb553e74e28e105fd 
  src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
  src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
  src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
  src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 

Diff: https://reviews.apache.org/r/43641/diff/


Testing
-------

`make check`


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message