mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Review Request 43661: Added check to not Subscribe if we are already subscribed.
Date Wed, 17 Feb 2016 19:22:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43661/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-3570
    https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
-------

This change adds a check to ensure that we don't `Subscribe` again in case we already have
a `SubscribedResponse` stream set. With pipelining, we won't be able to send more then 1 subscribe
calls on the `Subscribe` connection.

In case, the scheduler sends two subscribe calls simultaneously before the subscribed response
stream could be established. We would invoke the `disconnected`/`connected` callback, making
the scheduler subscribe again.


Diffs
-----

  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 

Diff: https://reviews.apache.org/r/43661/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message