mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 43437: Update slave tests to pass shared_ptrs to 'StartSlave'.
Date Thu, 11 Feb 2016 19:33:50 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 11, 2016, 11:33 a.m.)

Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Move some FUTURE_DISPATCH's on the MesosContainerizer after the destruction of a prior containerizer.

Bugs: MESOS-4633

Repository: mesos


Makes the following changes:

* All objects passed to `StartSlave` are transformed into `shared_ptr`.
* References to the above objects are updated to reflect the different type.
* Removes `Shutdown()` in at the end of all tests, except for master tests that have a stack-allocated
* Removes manual `delete`s inside tests.
* Generally renames test variables to be more consistent (i.e. `exec` -> `executor` and
`dockerContainerizer` -> `containerizer`).
* Removes extraneous spaces in `Try<PID<Slave> >` in touched lines.

Diffs (updated)

  src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67 
  src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a 



Tests are run at the very, very end of this review chain.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message