mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 43448: Update remaining tests to pass shared_ptrs to 'StartSlave'.
Date Wed, 10 Feb 2016 23:36:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43448/
-----------------------------------------------------------

Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Bugs: MESOS-4633
    https://issues.apache.org/jira/browse/MESOS-4633


Repository: mesos


Description
-------

Makes the following changes:

* All objects passed to `StartSlave` are transformed into `shared_ptr`.
* References to the above objects are updated to reflect the different type.
* Removes `Shutdown()` in at the end of all tests, except for master tests that have a stack-allocated
dependency.
* Removes manual `delete`s inside tests.
* Generally renames test variables to be more consistent (i.e. `exec` -> `executor` and
`dockerContainerizer` -> `containerizer`).
* Removes extraneous spaces in `Try<PID<Slave> >` in touched lines.


Diffs
-----

  src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
  src/tests/credentials_tests.cpp 7edcc857e0f6f8e80e265deeec59d6349d392224 
  src/tests/exception_tests.cpp 6b71316d545e97f14a45daa14d0fd95204befd3b 
  src/tests/registrar_zookeeper_tests.cpp 3df9779ee5d076e16f6a538326693a36f986b6d0 
  src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 
  src/tests/teardown_tests.cpp 5753559003d703138d2bbee6a1ac93473ba0b0c0 

Diff: https://reviews.apache.org/r/43448/diff/


Testing
-------

sudo make check

---------| OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | Ubuntu 12 |
 Non-SSL |  :) |    &     |    *@    |   X_X    |       x      |     *     |     *   
 |
With-SSL |  :) |    &%    |    *@    |   X_X    |       x      |     *     |     *   
 |

 :) = Passed.
X_X = Test suite exited prematurely
  * = Failed: LinuxFilesystemIsolatorTest.ROOT_ChangeRootFilesystemCommandExecutorPersistentVolume
  x = Failed: DockerContainerizerTest.ROOT_DOCKER_Logs
  @ = Failed: MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery
  % = Failed: LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids
  & = Failed: FetcherCacheHttpTest.HttpCachedSerialized, LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem,
LinuxFilesystemIsolatorTest.ROOT_MultipleContainers


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message