mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Review Request 43439: Update exec/sched driver tests to pass shared_ptrs to 'StartSlave'.
Date Wed, 10 Feb 2016 23:36:03 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Bernd Mathiske and Artem Harutyunyan.

Bugs: MESOS-4633

Repository: mesos


Makes the following changes:

* All objects passed to `StartSlave` are transformed into `shared_ptr`.
* References to the above objects are updated to reflect the different type.
* Removes `Shutdown()` in at the end of all tests, except for master tests that have a stack-allocated
* Removes manual `delete`s inside tests.
* Generally renames test variables to be more consistent (i.e. `exec` -> `executor` and
`dockerContainerizer` -> `containerizer`).
* Removes extraneous spaces in `Try<PID<Slave> >` in touched lines.


  src/tests/executor_http_api_tests.cpp 36a042ed103271ca873450236f39a8152fbbf07e 
  src/tests/scheduler_driver_tests.cpp f6dc25d82ae5f1e77fc6ede7ff2660ed0d9ea039 
  src/tests/scheduler_event_call_tests.cpp bd8920fa9d5475e5f6533c8424ebff1588bfe645 
  src/tests/scheduler_http_api_tests.cpp 9eb1de7d9541395b92b951f0fe0ddbb2f219fe30 
  src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 



Tests are run at the very, very end of this review chain.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message