mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 43450: Fixed typo in log message.
Date Wed, 10 Feb 2016 23:16:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43450/
-----------------------------------------------------------

(Updated Feb. 10, 2016, 11:16 p.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Tweak.


Repository: mesos


Description (updated)
-------

When the `uuid` field of `StatusUpdate` is not set, the output of
`operator<<(ostream& stream, const StatusUpdate& update)` contains a
mismatched parenthesis. In practice, this means we can omit log
messages that have a typo.


Diffs (updated)
-----

  src/messages/messages.cpp 89deee34948bcf0fadcabc0fbdd4356c0bd2ddb7 

Diff: https://reviews.apache.org/r/43450/diff/


Testing
-------

make check

Old log output:

```
Sending status update TASK_LOST) for task 33fa8ceb-f133-43c0-8a8d-9a77f83b825b of framework
06daa081-8522-42b1-a4d3-1160c1f0662d-0000 'Task launched with invalid offers: Offer 06daa081-8522-42b1-a4d3-1160c1f0662d-O1
is no longer valid'
```

New log output:

```
Sending status update TASK_LOST for task f3674b8a-5242-4864-8bab-cbb5f342de05 of framework
5bc9cf4c-4767-4800-92e1-b6b56d17edd3-0000 'Task launched with invalid offers: Offer 5bc9cf4c-4767-4800-92e1-b6b56d17edd3-O1
is no longer valid'
```


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message