mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 42754: Added support for labels to resource reservations.
Date Wed, 10 Feb 2016 18:59:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42754/
-----------------------------------------------------------

(Updated Feb. 10, 2016, 6:59 p.m.)


Review request for mesos and Michael Park.


Changes
-------

Address (most) review comments.


Bugs: MESOS-4479
    https://issues.apache.org/jira/browse/MESOS-4479


Repository: mesos


Description
-------

Labels are free-form key-value pairs that can be used to associate
metadata with reserved resources.


Diffs (updated)
-----

  include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
  include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a111154411 
  include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 
  include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 
  src/common/resources.cpp 588a279c3cdebbeb58047bfbff5e78a42f53fc13 
  src/common/type_utils.cpp 42e3061818c49c6b62d4fee2479db078dfe0fc89 
  src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f 
  src/tests/reservation_endpoints_tests.cpp 0a8c479b6684a4497f53c81c198bfcf8e879aa54 
  src/tests/resources_tests.cpp a190cc3900be72031e1c13e5843245f0f82dbf99 
  src/v1/mesos.cpp 21b14cf7050270facab1ba2b844c3fde664665a4 
  src/v1/resources.cpp be4a5d153e9313cb71a6e85d1ed25a358537f2b7 

Diff: https://reviews.apache.org/r/42754/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message