mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 43388: Revised authentication documentation.
Date Wed, 10 Feb 2016 00:49:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43388/#review118504
-----------------------------------------------------------


Fix it, then Ship it!





docs/authentication.md (line 11)
<https://reviews.apache.org/r/43388/#comment179755>

    I would just say the same thing that we did with frameworks above
    
    """
    To require that slaves be authenticated in order to register with the master.
    """



docs/authentication.md (lines 14 - 19)
<https://reviews.apache.org/r/43388/#comment179760>

    Since we modularized the authenticator, there is no strict dependency on SASL/CRAM-MD5.
So I would reword this to say that the default implementation uses SASL/CRAM-MD5.



docs/authentication.md (line 31)
<https://reviews.apache.org/r/43388/#comment179763>

    used by the slave to run tasks/executors


- Vinod Kone


On Feb. 10, 2016, 12:10 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43388/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Revised authentication documentation.
> 
> 
> Diffs
> -----
> 
>   docs/authentication.md b40b09eaceddc8e5498b54b3e8ef7a5dbd7b9dc2 
> 
> Diff: https://reviews.apache.org/r/43388/diff/
> 
> 
> Testing
> -------
> 
> Previewed in site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message