mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.
Date Tue, 09 Feb 2016 14:29:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43321/#review118391
-----------------------------------------------------------




src/tests/scheduler_tests.cpp (line 839)
<https://reviews.apache.org/r/43321/#comment179624>

    Do we need Clock::settle() here to make sure the `recoverResources` messages to be dispatched
and processed completely?



src/tests/scheduler_tests.cpp (line 850)
<https://reviews.apache.org/r/43321/#comment179625>

    Does this still needed?


- Guangya Liu


On 二月 8, 2016, 4:20 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43321/
> -----------------------------------------------------------
> 
> (Updated 二月 8, 2016, 4:20 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4175
>     https://issues.apache.org/jira/browse/MESOS-4175
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speeded up SchedulerTest.Decline by advancing the clock.
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad 
> 
> Diff: https://reviews.apache.org/r/43321/diff/
> 
> 
> Testing
> -------
> 
> sudo make check -j2 GTEST_FILTER='ContentType/SchedulerTest.Decline/*
> 
> ```sh
> [ RUN      ] ContentType/SchedulerTest.Decline/0
> [       OK ] ContentType/SchedulerTest.Decline/0 (114 ms)
> [ RUN      ] ContentType/SchedulerTest.Decline/1
> [       OK ] ContentType/SchedulerTest.Decline/1 (98 ms)
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message