mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 42689: Clarified a comment that occurs in several test cases.
Date Tue, 09 Feb 2016 06:39:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42689/#review118360
-----------------------------------------------------------



Looks good, but the patch doesn't apply cleanly anymore with `apply-reviews.py`. If you rebase
it, I'll commit it.

- Adam B


On Jan. 23, 2016, 3:05 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42689/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2016, 3:05 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Clarified a comment that occurs in several test cases.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 7acf7ab29d64d891f3288f8042d267dcc82a32e9 
>   src/tests/reservation_endpoints_tests.cpp 35c093567b07a11ca6eee85e2ff91894a460a7af

> 
> Diff: https://reviews.apache.org/r/42689/diff/
> 
> 
> Testing
> -------
> 
> Seems like these snuck in due to copy-and-pastes that were concurrent with the patch
to fixup the rest of the instances of this comment.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message