mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 42983: Implemented the `status` method in `MesosContainerizer`.
Date Mon, 08 Feb 2016 18:23:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42983/#review118262
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp (line 1317)
<https://reviews.apache.org/r/42983/#comment179486>

    s/aggregate/result/



src/slave/containerizer/mesos/containerizer.cpp (line 1330)
<https://reviews.apache.org/r/42983/#comment179487>

    Please remove this. we need to be very careful of adding INFO level logging.



src/slave/containerizer/mesos/containerizer.cpp (line 1341)
<https://reviews.apache.org/r/42983/#comment179485>

    s/Unable to get status for//



src/slave/containerizer/mesos/containerizer.cpp (lines 1352 - 1355)
<https://reviews.apache.org/r/42983/#comment179488>

    ```
    return await(futures).then(
        lambda::bind(_status, containerId, lambda::_1));
    ```


- Jie Yu


On Feb. 8, 2016, 6:43 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42983/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 6:43 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4487
>     https://issues.apache.org/jira/browse/MESOS-4487
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the `status` method in `MesosContainerizer`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 811ab7937279c4a55da450c136f9fcb1303ea0d5

>   src/slave/containerizer/mesos/containerizer.cpp 1e362d2756690368fde46a3a516c258d9ead2154

> 
> Diff: https://reviews.apache.org/r/42983/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message