mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.
Date Mon, 08 Feb 2016 18:14:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42947/#review118260
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 401)
<https://reviews.apache.org/r/42947/#comment179479>

    Indentation.



src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 412)
<https://reviews.apache.org/r/42947/#comment179480>

    s/CgroupInfo_NetCls/CgroupInfo::NetCls/



src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 413)
<https://reviews.apache.org/r/42947/#comment179481>

    why the extra '(' and ')'?



src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 416 - 417)
<https://reviews.apache.org/r/42947/#comment179482>

    This is not needed. Please kill it.


- Jie Yu


On Feb. 8, 2016, 6:44 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42947/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 6:44 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4489
>     https://issues.apache.org/jira/browse/MESOS-4489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the `status` method in `CgroupNetClsIsolatorProcess`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 3f8d07cad363c62e31adc1a756ebc7ff94b76db3

>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp fd674090d4b7f22b98571b693d71493d71b8e05e

> 
> Diff: https://reviews.apache.org/r/42947/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message