-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43267/#review118193
-----------------------------------------------------------
Looks good. Just a couple of minor issues.
src/tests/slave_tests.cpp (line 1339)
<https://reviews.apache.org/r/43267/#comment179418>
Can we just do:
`TestContainerizer containerizer1;` similar to what we do a few lines later in this test
for `containerizer2` to be consistent?
Another option can be to modify both the occurences and wrap them in `process::Owned`.
I would prefer the first option since we do so for all the other tests in this file too.
src/tests/slave_tests.cpp (line 1357)
<https://reviews.apache.org/r/43267/#comment179419>
Nit: I thought we decided to not do `Times(1)` explicitly in our test code?
src/tests/slave_tests.cpp (line 1397)
<https://reviews.apache.org/r/43267/#comment179420>
This expectation should be done before we invoke `StartSlave` to avoid a potential race.
- Anand Mazumdar
On Feb. 5, 2016, 10:46 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43267/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 10:46 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Bugs: MESOS-4066
> https://issues.apache.org/jira/browse/MESOS-4066
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will help operators hitting the /state endpoint by not returning incomplete
> data when slave is still recoverying.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 9167030e77efc7e1d0dc0c6bd800d20ba9c55e3c
> src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77
>
> Diff: https://reviews.apache.org/r/43267/diff/
>
>
> Testing
> -------
>
> make -j3 check GTEST_FILTER="*StateEndpointUnavailableDuringRecovery*"
>
> ./bin/mesos-tests.sh --gtest_filter="*StateEndpointUnavailableDuringRecovery*" --gtest_repeat=1000
--gtest_break_on_failure
>
> ./bin/mesos-tests.sh
>
>
> Thanks,
>
> Vinod Kone
>
>
|