mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.
Date Sat, 06 Feb 2016 03:59:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43107/#review118135
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Feb. 5, 2016, 10:27 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43107/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 10:27 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4344
>     https://issues.apache.org/jira/browse/MESOS-4344
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `cgroup/net_cls` isolator will use the primary handle, passed by the
> operator using the --cgroup_net_cls_primary_handle, to initialize the
> `NetClsHandleManager`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f96c3274610269eacc9e91fec21a47a06bfeea62

> 
> Diff: https://reviews.apache.org/r/43107/diff/
> 
> 
> Testing
> -------
> 
> make and make check
> 
> Launched a slave by passing invalid flags to --cgroup_net_cls_primary_handle and made
sure the slave correctly detects these invalid handles. 
> 
> Launched a slave with valid handle to make sure that the slave launches correctly.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message