mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 43216: Added json() function for jsonification of the global help process.
Date Fri, 05 Feb 2016 03:27:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43216/#review117960
-----------------------------------------------------------


Ship it!





3rdparty/libprocess/src/help.cpp (lines 135 - 149)
<https://reviews.apache.org/r/43216/#comment179252>

    How about:
    
    ```
    // Write the help strings contained in the help process to JSON.
    // The schema looks as follows:
    // {
    //   "processes":
    //   [
    //     {
    //       "id": id,
    //       "endpoints": [ { "name" : name, "text" : text }, ... ]
    //     },
    //     ...
    //   ]
    // }
    ```


- Ben Mahler


On Feb. 5, 2016, 3:22 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43216/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 3:22 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Bugs: MESOS-3831
>     https://issues.apache.org/jira/browse/MESOS-3831
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will be used to dump the help strings into a JSON object when
> hitting the /help endpoint with a specific request for JSON data.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/help.hpp 2e76a6a5b1069abce879374a88cea65036873f1d

>   3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae 
> 
> Diff: https://reviews.apache.org/r/43216/diff/
> 
> 
> Testing
> -------
> 
> Unit test in a subsequent commit.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message