mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 43217: Added ability to return the /help endpoint as a JSON object.
Date Fri, 05 Feb 2016 01:49:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43217/#review117938
-----------------------------------------------------------




3rdparty/libprocess/src/help.cpp (lines 185 - 192)
<https://reviews.apache.org/r/43217/#comment179235>

    Can you add a comment here for posterity, given that we discussed this quite a bit:
    
    ```
    // NOTE: We avoided relying on the 'Accept' header to
    // specify the format because if users are hitting the
    // endpoint from a browser it is difficult to change
    // the 'Accept' header.
    ```


- Ben Mahler


On Feb. 4, 2016, 8:39 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43217/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 8:39 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Bugs: MESOS-3831
>     https://issues.apache.org/jira/browse/MESOS-3831
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, the /help endpoint could only be returned as either pure
> markdown or html.
> 
> This commit introduces a query parameter: format=json to allow the
> help endpoint to return a JSON object containing the help information
> for all other endpoints.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae 
> 
> Diff: https://reviews.apache.org/r/43217/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message