mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.
Date Fri, 05 Feb 2016 00:05:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43096/#review117915
-----------------------------------------------------------


Fix it, then Ship it!





src/linux/cgroups.cpp (line 2471)
<https://reviews.apache.org/r/43096/#comment179177>

    use ' instead of `



src/linux/cgroups.cpp (line 2488)
<https://reviews.apache.org/r/43096/#comment179176>

    no need for this temp variable.


- Jie Yu


On Feb. 3, 2016, 10:41 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43096/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper function in cgroup for supporting net_cls subsystem.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 83b3e401ac69194bef496087dee32e0532b834ab 
>   src/linux/cgroups.cpp bbc1fb3c60e53dffb1e8029942725e7102eb9aee 
> 
> Diff: https://reviews.apache.org/r/43096/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message