mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 43136: Support libprocess build run in aarch64 cpu.
Date Thu, 04 Feb 2016 09:04:05 GMT


> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote:
> > Ship It!
> 
> haosdent huang wrote:
>     You combine `src/...` and `3rdparty/...` in a same patch, usually we split them into
different patches. And we have `support/hooks/pre-commit` to check this when you execute `git
commit`. Do you have already run `./bootstrap` in local?
> 
> haosdent huang wrote:
>     Could you check whether `.git/hooks/pre-commit` exist in your local machine and that
`reset --soft` and submit again? Usually it would execute `support/mesos_split.py` to make
sure `the commits are properly split between mesos, libprocess and stout.`.
> 
> haosdent huang wrote:
>     yes, it would generate two patches finally.
> 
> Andy Pang wrote:
>     Thanks,i have modify it.
> 
> haosdent huang wrote:
>     hmm, still not correct. Let me find a example for you.

I think you could refer to https://reviews.apache.org/r/41870/diff/4#index_header and https://reviews.apache.org/r/42015/diff/1#index_header
. Keep in mind `Depends On` and `Blocks` field in review board.

Usually you could do it by
```
git add 3rdparty
git commit ....
git add src
git commit ....
./support/post_review.py...
```


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117771
-----------------------------------------------------------


On Feb. 4, 2016, 8:56 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
>     https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8

>   src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9

> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> -------
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message