mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 42751: Tweaked some resource test cases.
Date Wed, 03 Feb 2016 17:34:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42751/#review117635
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/resources_tests.cpp (line 327)
<https://reviews.apache.org/r/42751/#comment178877>

    if you are checking and relying on the outcome (i.e. next line) shouldn't this be an Assert_EQ?



src/tests/resources_tests.cpp (line 957)
<https://reviews.apache.org/r/42751/#comment178880>

    I must say this pattern (distance(begin,end)) just to get the item count looks unintuitive
here.
    I see that is currently the easiest way given Resources, but maybe it makes sense to add
a count() or similar function to Resources (Not a real issue for me for this review).


- Joerg Schad


On Jan. 25, 2016, 10:59 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42751/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 10:59 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We should check that two reservations with the same role but different
> principals are considered distinct.
> 
> 
> Diffs
> -----
> 
>   src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 
> 
> Diff: https://reviews.apache.org/r/42751/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message