mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.
Date Wed, 03 Feb 2016 07:28:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43096/#review117583
-----------------------------------------------------------



Primarily trivial comments around style/error messages.


src/linux/cgroups.hpp (line 656)
<https://reviews.apache.org/r/43096/#comment178819>

    Should fit in one line?



src/linux/cgroups.cpp (line 2463)
<https://reviews.apache.org/r/43096/#comment178820>

    Ditto.



src/linux/cgroups.cpp (line 2471)
<https://reviews.apache.org/r/43096/#comment178821>

    Space after `net_cls.classid` and a colon too



src/linux/cgroups.cpp (line 2476)
<https://reviews.apache.org/r/43096/#comment178824>

    Wondering if we should return more info to the caller here?



src/linux/cgroups.cpp (line 2492)
<https://reviews.apache.org/r/43096/#comment178822>

    Space after colon



src/linux/cgroups.cpp (line 2495)
<https://reviews.apache.org/r/43096/#comment178823>

    Period at the end.


- Anand Mazumdar


On Feb. 3, 2016, 7:17 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43096/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 7:17 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper function in cgroup for supporting net_cls subsystem.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 83b3e401ac69194bef496087dee32e0532b834ab 
>   src/linux/cgroups.cpp bbc1fb3c60e53dffb1e8029942725e7102eb9aee 
> 
> Diff: https://reviews.apache.org/r/43096/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message