mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 43120: Removed site/Gemfile.lock.
Date Wed, 03 Feb 2016 00:59:42 GMT


> On Feb. 2, 2016, 7:27 p.m., Kevin Klues wrote:
> > You can't just remove this file.  It specifies the versions of everything that should
be installed in a fresh docker image upon calling 'bundle insgtall'.  If you saw that it was
being overwritten, it means you had a (possibly incompatible) newer version of some tools
already installed on your system, which was causing newer versions of things to be pulled
in.  We need this committed so that we have proper versioning for known good versions of the
tools installed on a fresh install.

The problem was that it wasn't getting overwritten :-). I had newer versions of tools; more
specifically, eventmachine version 1.0.9 was installed. However, this file expected version
1.0.3. So either I had to update or remove this file by hand before running rake. I wonder
if anyone else has run into such problems and if there are better alternatives.

For me, I ended up not using the docker image and just used the stuff from mesos source tree
to generate the publish folder,  but I understand that this might fail for others. In that
case, we can just drop this RR and continue with the other RRs :-).


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43120/#review117532
-----------------------------------------------------------


On Feb. 2, 2016, 7:15 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43120/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Neil Conway.
> 
> 
> Bugs: MESOS-4584
>     https://issues.apache.org/jira/browse/MESOS-4584
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This file is automatically generated by `bundle install` and can cause
> conflicts if pre-generated.
> 
> 
> Diffs
> -----
> 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
> 
> Diff: https://reviews.apache.org/r/43120/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message