mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.
Date Wed, 03 Feb 2016 00:52:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43107/
-----------------------------------------------------------

(Updated Feb. 3, 2016, 12:52 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Rebased.


Bugs: MESOS-4344
    https://issues.apache.org/jira/browse/MESOS-4344


Repository: mesos


Description
-------

The `cgroup/net_cls` isolator will use the primary handle, passed by the operator
using the --cgroup_net_cls_primary_handle, to initialize the `NetClsHandleMgr`.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e


Diff: https://reviews.apache.org/r/43107/diff/


Testing
-------

make and make check

Launched a slave by passing invalid flags to --cgroup_net_cls_primary_handle and made sure
the slave correctly detects these invalid handles. 

Launched a slave with valid handle to make sure that the slave launches correctly.


Thanks,

Avinash sridharan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message