mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 43075: Fixed definition of operator<< for `Call::Type` and `Event::Type`.
Date Tue, 02 Feb 2016 21:33:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43075/
-----------------------------------------------------------

(Updated Feb. 2, 2016, 9:33 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

New approach, per discussion with Vinod.


Summary (updated)
-----------------

Fixed definition of operator<< for `Call::Type` and `Event::Type`.


Repository: mesos


Description (updated)
-------

The types were defined in the `mesos::scheduler` namespace, but the
overload of `operator<<` was only defined in the `mesos` namespace.
Because of how ADL works, this usually resulted in the overload
not being found.

Old output: "Dropping 2 call from framework ..."

New output: "Dropping TEARDOWN call from framework ..."


Diffs (updated)
-----

  include/mesos/scheduler/scheduler.hpp cadd7df11bb6d4210c5abdab5c04586e6686af1d 
  src/sched/sched.cpp 8e51752536041b896e42d44e6e9eae909b0a1d68 

Diff: https://reviews.apache.org/r/43075/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message