mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 43075: Fixed error message when dropping a scheduler::Call message.
Date Tue, 02 Feb 2016 19:54:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43075/#review117459
-----------------------------------------------------------




src/master/master.cpp (line 1801)
<https://reviews.apache.org/r/43075/#comment178649>

    The output stream operator overload for Call (unversioned) defined in "mesos/scheduler/scheduler.hpp".
Not sure why the compiler unable to find that overload (defined in `mesos` namespace).
    
    It seems to work fine for log statements (that print v1::Call) in scheduler.cpp. The overload
for v1::Call was defined in "mesos/include/mesos/v1/scheduler/scheduler.cpp" though, which
is in the same namespace as the log statements in scheduler.cpp.


- Vinod Kone


On Feb. 2, 2016, 5:12 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43075/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 5:12 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Old output: "Dropping 2 call from framework ..."
> 
> New output: "Dropping TEARDOWN call from framework ..."
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83 
> 
> Diff: https://reviews.apache.org/r/43075/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message