mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 43021: Implemented docker runtime isolator interface.
Date Tue, 02 Feb 2016 18:29:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43021/#review117438
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/runtime.hpp (line 26)
<https://reviews.apache.org/r/43021/#comment178620>

    s/Isolator/isolator/



src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 23)
<https://reviews.apache.org/r/43021/#comment178621>

    We try to avoid using this now. Let's use 'using process::XXX' explicitly here.


- Jie Yu


On Feb. 2, 2016, 5:18 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43021/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 5:18 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4517
>     https://issues.apache.org/jira/browse/MESOS-4517
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented docker runtime isolator interface.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
>   src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43021/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message