mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Lunøe <michael.lu...@gmail.com>
Subject Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid
Date Mon, 01 Feb 2016 23:36:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43072/
-----------------------------------------------------------

Review request for mesos, Bernd Mathiske and Thomas Rampelberg.


Bugs: MESOS-2585
    https://issues.apache.org/jira/browse/MESOS-2585


Repository: mesos


Description
-------

The solution to our problem is solved by updating the Bootstrap CSS file, as container-fluid
was introduced later in Bootstrap.

I have updated to lastest stable release of Bootstrap v3.3.6. Looking through the change log,
the only thing that we are using in the Mesos UI and changed is the "hide" class (deprecated),
so instances of these have been replaced by its successor ".hidden" class.


Diffs
-----

  src/webui/master/static/browse.html 6b18056 
  src/webui/master/static/css/bootstrap-3.0.3.min.css c547283 
  src/webui/master/static/css/bootstrap-3.3.6.min.css PRE-CREATION 
  src/webui/master/static/framework.html 9b28820 
  src/webui/master/static/home.html d6cde1e 
  src/webui/master/static/index.html 25caf53 
  src/webui/master/static/slave.html bc46885 
  src/webui/master/static/slave_executor.html 9d582d5 
  src/webui/master/static/slave_framework.html 96d788f 

Diff: https://reviews.apache.org/r/43072/diff/


Testing
-------

- Mobile: http://cl.ly/2R2O0m1a1G3Q/Image%202016-02-01%20at%2015.21.53.png
- 1680 x 1050px screen: http://cl.ly/0K1o112u3L2I/Image%202016-02-01%20at%2015.23.37.png
- 2880 x 1800px screen: http://cl.ly/1M0L3M2X0J2i/Image%202016-02-01%20at%2015.22.50.png

Visual test in latest Chrome, Firefox, Safari and IE. No functional changes introduced.


Thanks,

Michael Lunøe


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message