mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <>
Subject Re: Review Request 42617: Cleaned up usage of namespace-qualified identifiers in stout.
Date Mon, 01 Feb 2016 22:07:29 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 1, 2016, 10:07 p.m.)

Review request for mesos and Michael Park.


Fix commit message style

Summary (updated)

Cleaned up usage of namespace-qualified identifiers in stout.

Repository: mesos


For example, avoid using `std::string` in a .cpp file that already does
`using std::string`.

Diffs (updated)

  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 5a10f59f3698a6ad85b7c2386def9686af8a23a6

  3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 21a98b85277d946b887cb23c4ebb4d32cfcb0c6b

  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 01e4b2fff7cc05a47d7919d702543a38bf6c339d

  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 4b7d1347f93261df7a7d512721146edca2703b34

  3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp c0be974ea2dc74c63ec3561403b3f4d3722a8df3

  3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 7715fa4baa150f370bdd0fd5c2f98dc4c6f5fc55



"make check" on OSX and Arch Linux.


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message