mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <>
Subject Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.
Date Mon, 01 Feb 2016 21:40:21 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 1, 2016, 9:40 p.m.)

Review request for mesos and Joris Van Remoortere.


Tweak expectation to be stronger.

Repository: mesos


Check that even though we might fire a timer for a `GroupProcess` that has been
destroyed, this does not result in dispatching an event to a reclaimed process.

Diffs (updated)

  src/tests/group_tests.cpp 6344fade519f47cd4ac3a2dc36c3237d9adf4cf8 



`make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" --gtest_repeat=4000

I also verified that if you remove the `delete` of the `GroupProcess`, the test fails because
the `expired` callback is invoked (the `Clock::settle()` is necessary to ensure that this


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message