mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jian Qiu <qiuj...@cn.ibm.com>
Subject Re: Review Request 42591: Added Framework protobufs to registry.
Date Mon, 01 Feb 2016 08:34:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42591/#review117192
-----------------------------------------------------------




src/master/registry.proto (line 58)
<https://reviews.apache.org/r/42591/#comment178298>

    Why do we persist these fields instead of the whole frameworkInfo or frameworkId only?


- Jian Qiu


On 二月 1, 2016, 7:23 a.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42591/
> -----------------------------------------------------------
> 
> (Updated 二月 1, 2016, 7:23 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Klaus Ma, Klaus Ma, Qian Zhang, Jian
Qiu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1719
>     https://issues.apache.org/jira/browse/MESOS-1719
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add the protobufs in registry to persist some framework informations which do not allow
to change when framework re-register.
> 
> 
> Diffs
> -----
> 
>   src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
> 
> Diff: https://reviews.apache.org/r/42591/diff/
> 
> 
> Testing
> -------
> 
> Make && Make check successfully
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message