mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.
Date Mon, 01 Feb 2016 05:14:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43023/
-----------------------------------------------------------

(Updated Feb. 1, 2016, 5:14 a.m.)


Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Changes
-------

Addressed Neil and Joris' comments.


Bugs: MESOS-4566
    https://issues.apache.org/jira/browse/MESOS-4566


Repository: mesos


Description (updated)
-------

With this + https://reviews.apache.org/r/43024/, the number of calls to
`operator new` and `operator delete` were reduced by roughly 1/3.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp f9d72243bcd5ae951ae1837fef0842915ff1e896


Diff: https://reviews.apache.org/r/43023/diff/


Testing
-------

`make check`


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message