mesos-reviews mailing list archives: January 2016

Site index · List index
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · 10 · 11 · 12 · 13 · 14 · 15 · Next »Thread · Author · Date
Alexander Rukletsov Review Request 42657: Corrected a typo in allocator tests. Fri, 22 Jan, 21:00
Alexander Rukletsov   Re: Review Request 42657: Corrected a typo in allocator tests. Thu, 28 Jan, 13:08
Alexander Rukletsov Review Request 42658: Restructured comments in allocator tests for clarity. Fri, 22 Jan, 21:01
Alexander Rukletsov   Re: Review Request 42658: Restructured comments in allocator tests for clarity. Thu, 28 Jan, 13:11
Kapil Arya Review Request 42518: Disabled "drop_log_memory" flag for glog. Fri, 22 Jan, 22:14
Kapil Arya   Re: Review Request 42518: Disabled "drop_log_memory" flag for glog. Sat, 23 Jan, 03:59
Ben Mahler     Re: Review Request 42518: Disabled "drop_log_memory" flag for glog. Sat, 23 Jan, 22:37
Mesos ReviewBot     Re: Review Request 42518: Disabled "drop_log_memory" flag for glog. Sun, 24 Jan, 00:26
Alexander Rukletsov Review Request 42672: Explicitly checked for the absence of allocation. Fri, 22 Jan, 23:21
Guangya Liu   Re: Review Request 42672: Explicitly checked for the absence of allocation. Sat, 23 Jan, 06:31
Alexander Rukletsov     Re: Review Request 42672: Explicitly checked for the absence of allocation. Thu, 28 Jan, 13:22
Mesos ReviewBot   Re: Review Request 42672: Explicitly checked for the absence of allocation. Sat, 23 Jan, 12:23
Alexander Rukletsov   Re: Review Request 42672: Explicitly checked for the absence of allocation. Thu, 28 Jan, 13:22
Neil Conway Review Request 42673: Silenced two more GMock warnings about shutdown expectations. Fri, 22 Jan, 23:38
Mesos ReviewBot   Re: Review Request 42673: Silenced two more GMock warnings about shutdown expectations. Sat, 23 Jan, 08:03
Timothy Chen   Re: Review Request 42673: Silenced two more GMock warnings about shutdown expectations. Thu, 28 Jan, 08:05
Timothy Chen Review Request 42674: Replaced busybox with alpine in docker tests. Sat, 23 Jan, 00:02
Isabel Jimenez   Re: Review Request 42674: Replaced busybox with alpine in docker tests. Sat, 23 Jan, 00:14
Isabel Jimenez     Re: Review Request 42674: Replaced busybox with alpine in docker tests. Sat, 23 Jan, 00:24
Timothy Chen     Re: Review Request 42674: Replaced busybox with alpine in docker tests. Sat, 23 Jan, 01:26
Guangya Liu   Re: Review Request 42674: Replaced busybox with alpine in docker tests. Sat, 23 Jan, 01:00
Timothy Chen     Re: Review Request 42674: Replaced busybox with alpine in docker tests. Sat, 23 Jan, 01:26
Guangya Liu     Re: Review Request 42674: Replaced busybox with alpine in docker tests. Sat, 23 Jan, 02:17
Timothy Chen   Re: Review Request 42674: Replaced busybox with alpine in docker tests. Sat, 23 Jan, 01:26
Jie Yu     Re: Review Request 42674: Replaced busybox with alpine in docker tests. Sat, 23 Jan, 17:40
Guangya Liu       Re: Review Request 42674: Replaced busybox with alpine in docker tests. Sun, 24 Jan, 07:54
Bernd Mathiske       Re: Review Request 42674: Replaced busybox with alpine in docker tests. Mon, 25 Jan, 08:43
Guangya Liu       Re: Review Request 42674: Replaced busybox with alpine in docker tests. Mon, 25 Jan, 08:50
Timothy Chen       Re: Review Request 42674: Replaced busybox with alpine in docker tests. Mon, 25 Jan, 19:15
Mesos ReviewBot     Re: Review Request 42674: Replaced busybox with alpine in docker tests. Sat, 23 Jan, 19:58
Bernd Mathiske     Re: Review Request 42674: Replaced busybox with alpine in docker tests. Mon, 25 Jan, 08:43
Timothy Chen       Re: Review Request 42674: Replaced busybox with alpine in docker tests. Tue, 26 Jan, 06:23
Timothy Chen     Re: Review Request 42674: Replaced busybox with alpine in docker tests. Mon, 25 Jan, 19:18
Jie Yu       Re: Review Request 42674: Replaced busybox with alpine in docker tests. Mon, 25 Jan, 19:26
Isabel Jimenez       Re: Review Request 42674: Replaced busybox with alpine in docker tests. Mon, 25 Jan, 20:46
Vinod Kone Review Request 42677: Updated ReviewBot to truncate the output of review. Sat, 23 Jan, 00:38
Vinod Kone   Re: Review Request 42677: Updated ReviewBot to truncate the output of review. Sat, 23 Jan, 00:39
Michael Park     Re: Review Request 42677: Updated ReviewBot to truncate the output of review. Sat, 23 Jan, 01:29
Klaus Ma Review Request 42678: Avoid `slave.total` do not contain `slave.allocated` in allocator. Sat, 23 Jan, 00:57
Klaus Ma   Re: Review Request 42678: WIP: Avoid `slave.total` do not contain `slave.allocated` in allocator. Sat, 23 Jan, 01:16
Mesos ReviewBot     Re: Review Request 42678: WIP: Avoid `slave.total` do not contain `slave.allocated` in allocator. Sat, 23 Jan, 10:27
Re: Review Request 41299: Allow DockerContainerizer log to console.
haosdent huang   Re: Review Request 41299: Allow DockerContainerizer log to console. Sat, 23 Jan, 08:58
Mesos ReviewBot     Re: Review Request 41299: Allow DockerContainerizer log to console. Sat, 23 Jan, 14:18
Guangya Liu     Re: Review Request 41299: Allow DockerContainerizer log to console. Sun, 24 Jan, 08:21
haosdent huang       Re: Review Request 41299: Allow DockerContainerizer log to console. Sun, 24 Jan, 08:26
Joris Van Remoortere Review Request 42683: Multiple Disk: Added Resource arithmetic tests for type 'MOUNT'. Sat, 23 Jan, 10:52
Jie Yu   Re: Review Request 42683: Multiple Disk: Added Resource arithmetic tests for type 'MOUNT'. Sat, 23 Jan, 17:24
Joris Van Remoortere   Re: Review Request 42683: Multiple Disk: Added Resource arithmetic tests for type 'MOUNT'. Sun, 24 Jan, 01:00
Joris Van Remoortere     Re: Review Request 42683: Multiple Disk: Added Resource arithmetic tests for type 'MOUNT'. Sun, 24 Jan, 01:19
Joris Van Remoortere Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type. Sat, 23 Jan, 10:57
Mesos ReviewBot   Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type. Sat, 23 Jan, 15:28
Jie Yu   Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type. Sat, 23 Jan, 17:33
Joris Van Remoortere   Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type. Sun, 24 Jan, 01:02
Joris Van Remoortere     Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type. Sun, 24 Jan, 01:08
Joris Van Remoortere       Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type. Sun, 24 Jan, 01:33
Mesos ReviewBot         Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type. Sun, 24 Jan, 03:19
Joris Van Remoortere         Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type. Tue, 26 Jan, 19:49
Joris Van Remoortere           Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type. Tue, 26 Jan, 20:20
Mesos ReviewBot             Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type. Tue, 26 Jan, 21:52
Qian Zhang Review Request 42685: Added roles validation to master. Sat, 23 Jan, 12:47
Mesos ReviewBot   Re: Review Request 42685: Added roles validation to master. Sat, 23 Jan, 16:39
Benjamin Bannier   Re: Review Request 42685: Added roles validation to master. Tue, 26 Jan, 01:32
Benjamin Bannier     Re: Review Request 42685: Added roles validation to master. Tue, 26 Jan, 01:35
Qian Zhang     Re: Review Request 42685: Added roles validation to master. Wed, 27 Jan, 05:27
Qian Zhang   Re: Review Request 42685: Added roles validation to master. Wed, 27 Jan, 05:26
Mesos ReviewBot     Re: Review Request 42685: Added roles validation to master. Wed, 27 Jan, 08:59
haosdent huang Review Request 42686: Fix warning about _FORTIFY_SOURCE flag when compile python package. Sat, 23 Jan, 15:28
haosdent huang   Re: Review Request 42686: Fix warning about _FORTIFY_SOURCE flag when compile python package. Sat, 23 Jan, 15:29
Mesos ReviewBot     Re: Review Request 42686: Fix warning about _FORTIFY_SOURCE flag when compile python package. Sat, 23 Jan, 18:30
haosdent huang     Re: Review Request 42686: Fix warning about _FORTIFY_SOURCE flag when compile python package. Sat, 23 Jan, 18:32
Neil Conway Review Request 42688: Fixed equality semantics for Labels. Sat, 23 Jan, 20:04
Mesos ReviewBot   Re: Review Request 42688: Fixed equality semantics for Labels. Sat, 23 Jan, 21:22
Neil Conway Review Request 42689: Clarified a comment that occurs in several test cases. Sat, 23 Jan, 23:05
Mesos ReviewBot   Re: Review Request 42689: Clarified a comment that occurs in several test cases. Sun, 24 Jan, 01:54
haosdent huang Review Request 42691: Fix GMock warning in MasterTest.OrphanTasks. Sun, 24 Jan, 03:44
haosdent huang   Re: Review Request 42691: Fix GMock warning in MasterTest.OrphanTasks. Sun, 24 Jan, 03:45
Mesos ReviewBot     Re: Review Request 42691: Fix GMock warning in MasterTest.OrphanTasks. Sun, 24 Jan, 04:57
Guangya Liu Review Request 42695: Correct typo when create docker container. Sun, 24 Jan, 13:33
Mesos ReviewBot   Re: Review Request 42695: Correct typo when create docker container. Sun, 24 Jan, 14:50
haosdent huang Review Request 42696: Speed up FetcherCacheTest.Local* test cases. Sun, 24 Jan, 15:01
Mesos ReviewBot   Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases. Sun, 24 Jan, 15:56
Bernd Mathiske   Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases. Tue, 26 Jan, 09:18
haosdent huang     Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases. Wed, 27 Jan, 03:47
haosdent huang   Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases. Wed, 27 Jan, 03:04
Mesos ReviewBot     Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases. Wed, 27 Jan, 06:00
haosdent huang Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation. Sun, 24 Jan, 15:18
haosdent huang   Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation. Sun, 24 Jan, 15:26
Joerg Schad     Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation. Sun, 24 Jan, 15:28
haosdent huang       Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation. Sun, 24 Jan, 15:35
Joerg Schad       Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation. Sun, 24 Jan, 15:46
haosdent huang       Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation. Sun, 24 Jan, 15:55
Joerg Schad       Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation. Sun, 24 Jan, 15:58
Review Request 42704: Fixed non-linux build involving glog drop_log_meory flag.
Kapil Arya   Review Request 42704: Fixed non-linux build involving glog drop_log_meory flag. Mon, 25 Jan, 05:42
Neil Conway   Re: Review Request 42704: Fixed non-linux build involving glog drop_log_meory flag. Mon, 25 Jan, 05:57
Yongqiao Wang Review Request 42705: Update docs for --weights flag and authorization. Mon, 25 Jan, 05:54
Mesos ReviewBot   Re: Review Request 42705: Update docs for --weights flag and authorization. Mon, 25 Jan, 06:42
Guangya Liu Review Request 42710: Moved docker containerizer to docker folder. Mon, 25 Jan, 07:06
Mesos ReviewBot   Re: Review Request 42710: Moved docker containerizer to docker folder. Mon, 25 Jan, 07:54
Guangya Liu   Re: Review Request 42710: WIP: Moved docker containerizer to docker folder. Mon, 25 Jan, 09:29
Mesos ReviewBot     Re: Review Request 42710: WIP: Moved docker containerizer to docker folder. Mon, 25 Jan, 10:49
Guangya Liu     Re: Review Request 42710: Moved docker containerizer to docker folder. Mon, 25 Jan, 12:23
Re: Review Request 42603: Added an http::Authenticator factory.
Alexander Rojas   Re: Review Request 42603: Added an http::Authenticator factory. Mon, 25 Jan, 12:44
Jan Schlicht     Re: Review Request 42603: Added an http::Authenticator factory. Wed, 27 Jan, 14:29
Alexander Rojas       Re: Review Request 42603: Added an http::Authenticator factory. Wed, 27 Jan, 15:07
Alexander Rojas       Re: Review Request 42603: Added an http::Authenticator factory. Wed, 27 Jan, 15:08
Alexander Rojas     Re: Review Request 42603: Added an http::Authenticator factory. Wed, 27 Jan, 15:38
Benjamin Bannier       Re: Review Request 42603: Added an http::Authenticator factory. Wed, 27 Jan, 16:51
Alexander Rojas       Re: Review Request 42603: Added an http::Authenticator factory. Wed, 27 Jan, 21:22
Benjamin Bannier         Re: Review Request 42603: Added an http::Authenticator factory. Wed, 27 Jan, 23:16
Re: Review Request 42648: Moved http authenticator initialization to main.
Alexander Rojas   Re: Review Request 42648: Moved http authenticator initialization to main. Mon, 25 Jan, 12:57
Alexander Rojas     Re: Review Request 42648: Moved http authenticator initialization to main. Wed, 27 Jan, 18:50
Alexander Rojas       Re: Review Request 42648: Moved http authenticator initialization to main. Wed, 27 Jan, 21:23
Benjamin Bannier         Re: Review Request 42648: Moved http authenticator initialization to main. Wed, 27 Jan, 23:16
Yongqiao Wang Review Request 42719: Add doc for weights. Mon, 25 Jan, 15:00
Mesos ReviewBot   Re: Review Request 42719: Add doc for weights. Mon, 25 Jan, 17:05
Re: Review Request 42690: Moved ExecutorInfo and Option TaskInfo into ContainerConfig.
Gilbert Song   Re: Review Request 42690: Moved ExecutorInfo and Option TaskInfo into ContainerConfig. Mon, 25 Jan, 17:20
Srinivas Brahmaroutu Review Request 42728: Changed code to add text description when Http call returns Forbidden. Mon, 25 Jan, 18:47
Mesos ReviewBot   Re: Review Request 42728: Changed code to add text description when Http call returns Forbidden. Mon, 25 Jan, 19:41
David Forsythe Review Request 42735: Make commit-msg hook portable. Mon, 25 Jan, 20:07
Mesos ReviewBot   Re: Review Request 42735: Make commit-msg hook portable. Mon, 25 Jan, 21:24
Ian Downes   Re: Review Request 42735: Make commit-msg hook portable. Mon, 25 Jan, 21:52
David Forsythe     Re: Review Request 42735: Make commit-msg hook portable. Tue, 26 Jan, 08:40
David Forsythe   Re: Review Request 42735: Make commit-msg hook portable. Tue, 26 Jan, 08:40
David Forsythe     Re: Review Request 42735: Make bash scripts portable. Tue, 26 Jan, 08:42
Review Request 42739: Accounted for reserved resources in the quota guarantee check.
Michael Park   Review Request 42739: Accounted for reserved resources in the quota guarantee check. Mon, 25 Jan, 20:45
Michael Park   Re: Review Request 42739: Accounted for reserved resources in the quota guarantee check. Tue, 26 Jan, 23:01
Michael Park     Re: Review Request 42739: Accounted for reserved resources in the quota guarantee check. Wed, 27 Jan, 00:16
Joris Van Remoortere       Re: Review Request 42739: Accounted for reserved resources in the quota guarantee check. Wed, 27 Jan, 01:27
Michael Park   Re: Review Request 42739: Accounted for reserved resources in the quota guarantee check. Wed, 27 Jan, 00:14
Greg Mann Review Request 42733: Added checks for presence of `ReservationInfo.principal`. Mon, 25 Jan, 21:02
Neil Conway   Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`. Mon, 25 Jan, 21:05
Greg Mann     Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`. Mon, 25 Jan, 21:10
Mesos ReviewBot   Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`. Mon, 25 Jan, 22:23
Re: Review Request 42746: Updated the allocator to offer revocable resources beyond quota.
Michael Park   Re: Review Request 42746: Updated the allocator to offer revocable resources beyond quota. Mon, 25 Jan, 22:08
Neil Conway Review Request 42750: Used `std::any_of` instead of `std::count_if` when validating IDs. Mon, 25 Jan, 22:49
Mesos ReviewBot   Re: Review Request 42750: Used `std::any_of` instead of `std::count_if` when validating IDs. Mon, 25 Jan, 23:22
Neil Conway Review Request 42751: Tweaked some resource test cases. Mon, 25 Jan, 22:58
Neil Conway   Re: Review Request 42751: Tweaked some resource test cases. Mon, 25 Jan, 22:59
Guangya Liu     Re: Review Request 42751: Tweaked some resource test cases. Tue, 26 Jan, 06:37
Neil Conway       Re: Review Request 42751: Tweaked some resource test cases. Tue, 26 Jan, 17:36
Neil Conway Review Request 42752: Fixed some typos in test case comments. Mon, 25 Jan, 22:59
Neil Conway Review Request 42753: Allowed `createLabel` to take an optional "value". Mon, 25 Jan, 23:00
Neil Conway Review Request 42754: Added support for labels to resource reservations. Mon, 25 Jan, 23:01
Neil Conway   Re: Review Request 42754: Added support for labels to resource reservations. Mon, 25 Jan, 23:02
Guangya Liu     Re: Review Request 42754: Added support for labels to resource reservations. Tue, 26 Jan, 08:03
Neil Conway       Re: Review Request 42754: Added support for labels to resource reservations. Tue, 26 Jan, 18:35
Guangya Liu       Re: Review Request 42754: Added support for labels to resource reservations. Wed, 27 Jan, 02:31
Neil Conway     Re: Review Request 42754: Added support for labels to resource reservations. Tue, 26 Jan, 18:34
Guangya Liu       Re: Review Request 42754: Added support for labels to resource reservations. Wed, 27 Jan, 03:02
Neil Conway Review Request 42755: Added documentation for labeled reserved resources. Mon, 25 Jan, 23:02
Mesos ReviewBot   Re: Review Request 42755: Added documentation for labeled reserved resources. Tue, 26 Jan, 01:26
Guangya Liu   Re: Review Request 42755: Added documentation for labeled reserved resources. Tue, 26 Jan, 08:11
Qian Zhang   Re: Review Request 42755: Added documentation for labeled reserved resources. Fri, 29 Jan, 00:23
Qian Zhang   Re: Review Request 42755: Added documentation for labeled reserved resources. Fri, 29 Jan, 01:25
David Forsythe Review Request 42757: Split os::memory() out into platform specific files. Mon, 25 Jan, 23:11
Mesos ReviewBot   Re: Review Request 42757: Split os::memory() out into platform specific files. Tue, 26 Jan, 02:16
Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.
M Lawindi   Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build. Mon, 25 Jan, 23:21
M Lawindi   Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build. Tue, 26 Jan, 20:18
Mesos ReviewBot     Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build. Tue, 26 Jan, 20:47
Alex Clemmer   Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build. Wed, 27 Jan, 10:12
Joris Van Remoortere Review Request 42761: Resource Math: Substituted DeleteSubrange with Swap + RemoveLast. Tue, 26 Jan, 00:10
Neil Conway   Re: Review Request 42761: Resource Math: Substituted DeleteSubrange with Swap + RemoveLast. Tue, 26 Jan, 00:28
Joris Van Remoortere   Re: Review Request 42761: Resource Math: Substituted DeleteSubrange with Swap + RemoveLast. Tue, 26 Jan, 05:38
Neil Conway     Re: Review Request 42761: Resource Math: Substituted DeleteSubrange with Swap + RemoveLast. Tue, 26 Jan, 05:41
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · 10 · 11 · 12 · 13 · 14 · 15 · Next »Thread · Author · Date
Box list
Oct 202046
Sep 2020188
Aug 2020388
Jul 2020125
Jun 202033
May 2020154
Apr 2020285
Mar 2020342
Feb 2020191
Jan 2020303
Dec 2019159
Nov 2019239
Oct 2019162
Sep 2019312
Aug 2019540
Jul 2019707
Jun 2019621
May 2019472
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338