From reviews-return-22358-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sun Jan 31 21:57:39 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E3ABD184D9 for ; Sun, 31 Jan 2016 21:57:38 +0000 (UTC) Received: (qmail 17307 invoked by uid 500); 31 Jan 2016 21:57:38 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 17276 invoked by uid 500); 31 Jan 2016 21:57:38 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 17257 invoked by uid 99); 31 Jan 2016 21:57:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 31 Jan 2016 21:57:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 922B11D9C17; Sun, 31 Jan 2016 21:57:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9042878914883479131==" MIME-Version: 1.0 Subject: Re: Review Request 43024: Avoid unnecessary string copies in `json` for protobuf messages. From: Joris Van Remoortere To: Benjamin Hindman Cc: Joris Van Remoortere , Michael Park , mesos Date: Sun, 31 Jan 2016 21:57:37 -0000 Message-ID: <20160131215737.30947.30341@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joris Van Remoortere X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43024/ X-Sender: Joris Van Remoortere X-ReviewBoard-ShipIt: 1 References: <20160131000649.26678.47705@reviews.apache.org> In-Reply-To: <20160131000649.26678.47705@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Joris Van Remoortere X-ReviewRequest-Repository: mesos --===============9042878914883479131== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43024/#review117159 ----------------------------------------------------------- Ship it! Ship It! - Joris Van Remoortere On Jan. 31, 2016, 12:06 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43024/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2016, 12:06 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4566 > https://issues.apache.org/jira/browse/MESOS-4566 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 6d7d033884cc6ed451e25bfc4638ac9186bbbcf5 > > Diff: https://reviews.apache.org/r/43024/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > > --===============9042878914883479131==--