From reviews-return-22317-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sun Jan 31 00:49:37 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 63D7F1803C for ; Sun, 31 Jan 2016 00:49:37 +0000 (UTC) Received: (qmail 20555 invoked by uid 500); 31 Jan 2016 00:49:37 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 20520 invoked by uid 500); 31 Jan 2016 00:49:37 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 20506 invoked by uid 99); 31 Jan 2016 00:49:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 31 Jan 2016 00:49:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B5D03289D19; Sun, 31 Jan 2016 00:49:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5087602726303766685==" MIME-Version: 1.0 Subject: Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively. From: Mesos ReviewBot To: Joris Van Remoortere Cc: Mesos ReviewBot , Neil Conway , mesos Date: Sun, 31 Jan 2016 00:49:35 -0000 Message-ID: <20160131004935.25059.75003@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42988/ X-Sender: Mesos ReviewBot References: <20160130222041.25059.8861@reviews.apache.org> In-Reply-To: <20160130222041.25059.8861@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============5087602726303766685== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/#review117130 ----------------------------------------------------------- Patch looks great! Reviews applied: [42987, 42988] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Jan. 30, 2016, 10:20 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42988/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2016, 10:20 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-4546 > https://issues.apache.org/jira/browse/MESOS-4546 > > > Repository: mesos > > > Description > ------- > > The previous implementation of `GroupProcess` tried to establish a single > ZooKeeper connection on startup, but didn't attempt to retry. ZooKeeper will > retry internally, but it only retries by attempting to reconnect to a list of > previously resolved IPs; it doesn't attempt to re-resolve those IPs to pickup > updates to DNS configuration. Because DNS configuration can be quite dynamic, > we now close the current Zk handle and open a new one if we've seen a > successful `zookeeper_init` but haven't been connected within the ZooKeeper > session timeout. > > > Diffs > ----- > > src/tests/group_tests.cpp 77349465e0163c8aa6bed6deefe3f98efb442f3d > src/zookeeper/group.hpp cf82fec290a2fa9bec122539c2eb0f12b45c2fb2 > src/zookeeper/group.cpp 2ae3193e0e138c90b205d45400d80e80853e1b99 > src/zookeeper/zookeeper.cpp 3c4fdad972dcd1728c52a05970646c713dcf98c8 > > Diff: https://reviews.apache.org/r/42988/diff/ > > > Testing > ------- > > make check, on both OSX and Arch Linux. Manually configured a situation in which the Mesos agent uses stale DNS information in a loop: validated that without the patch, we don't pickup DNS changes, whereas with the patch, we do. > > Also added a new unit test. Verified that the test fails w/o this patch applied and passes deterministically (`gtest_repeat=100`) with the patch applied. > > > Thanks, > > Neil Conway > > --===============5087602726303766685==--