From reviews-return-22237-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jan 29 21:47:20 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 861B41886B for ; Fri, 29 Jan 2016 21:47:20 +0000 (UTC) Received: (qmail 78775 invoked by uid 500); 29 Jan 2016 21:47:20 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 78748 invoked by uid 500); 29 Jan 2016 21:47:20 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 78731 invoked by uid 99); 29 Jan 2016 21:47:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jan 2016 21:47:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 64FA8289C20; Fri, 29 Jan 2016 21:47:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7403349791841021315==" MIME-Version: 1.0 Subject: Re: Review Request 42929: Updated docker_build.sh to make build environment configurable. From: Vinod Kone To: Kevin Klues , Anand Mazumdar , Greg Mann Cc: Mesos ReviewBot , Vinod Kone , mesos Date: Fri, 29 Jan 2016 21:47:19 -0000 Message-ID: <20160129214719.12173.13966@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42929/ X-Sender: Vinod Kone References: <20160129010110.12172.95729@reviews.apache.org> In-Reply-To: <20160129010110.12172.95729@reviews.apache.org> Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============7403349791841021315== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 29, 2016, 1:01 a.m., Kevin Klues wrote: > > Ship It! > > Kevin Klues wrote: > Actually, would it be possible to make the --no-cache=true option configurable as well? This is useful when running locally to speed up the build process when I know nothing significant has changed. I'll let you do that in a separate patch :) - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116854 ----------------------------------------------------------- On Jan. 29, 2016, 1:32 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42929/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2016, 1:32 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. > > > Bugs: MESOS-4523 > https://issues.apache.org/jira/browse/MESOS-4523 > > > Repository: mesos > > > Description > ------- > > Updated docker_build.sh to make build environment configurable. > > > Diffs > ----- > > support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 > support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 > > Diff: https://reviews.apache.org/r/42929/diff/ > > > Testing > ------- > > Tested this via a custom CI job on ASF CI. > > Note that the benchmark tests need to be reconfigured to not take a long time. Currently they get aborted because they ran for > 5 hours. > > > Thanks, > > Vinod Kone > > --===============7403349791841021315==--