From reviews-return-22224-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jan 29 20:51:56 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7C35118629 for ; Fri, 29 Jan 2016 20:51:56 +0000 (UTC) Received: (qmail 51770 invoked by uid 500); 29 Jan 2016 20:51:56 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 51741 invoked by uid 500); 29 Jan 2016 20:51:56 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 51726 invoked by uid 99); 29 Jan 2016 20:51:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jan 2016 20:51:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 66CFE289B94; Fri, 29 Jan 2016 20:51:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5370795866639244206==" MIME-Version: 1.0 Subject: Re: Review Request 42936: Edited flag help strings for style. From: Greg Mann To: Vinod Kone Cc: Mesos ReviewBot , Klaus Ma , Greg Mann , mesos Date: Fri, 29 Jan 2016 20:51:55 -0000 Message-ID: <20160129205155.12172.82711@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42936/ X-Sender: Greg Mann References: <20160129200201.12172.27454@reviews.apache.org> In-Reply-To: <20160129200201.12172.27454@reviews.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============5370795866639244206== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42936/ ----------------------------------------------------------- (Updated Jan. 29, 2016, 8:51 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-4298 https://issues.apache.org/jira/browse/MESOS-4298 Repository: mesos Description ------- Edited flag help strings for style. Backticks were inserted where appropriate. This not only matches the convention in the comments within our code, helps to enable the automatic generation of markdown-formatted documentation from these help strings. Diffs (updated) ----- src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 Diff: https://reviews.apache.org/r/42936/diff/ Testing ------- `make check` Thanks, Greg Mann --===============5370795866639244206==--